On 1/6/23 11:37, Eelco Chaudron wrote:
>
>
> On 5 Jan 2023, at 21:24, Mike Pattrick wrote:
>
>> Currently tc offload flow packet counters will roll over every ~4
>> billion packets. This is because the packet counter in struct
>> tc_stats provided by TCA_STATS_BASIC is a 32bit integer.
>>
>> Now we check for the optional TCA_STATS_PKT64 attribute which provides
>> the full 64bit packet counter if the 32bit one has rolled over. Because
>> the TCA_STATS_PKT64 attribute may appear multiple times in a netlink
>> message, the method of parsing attributes was changed.
>>
>> Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
>> Signed-off-by: Mike Pattrick <[email protected]>
>>
>> ---
>>
>> Since v1:
>> - Retain support for pre-TCA_STATS_PKT64 kernels
>> Since v2:
>> - Added compat header
>> Since v3:
>> - Rebased on to current master
>> Since v4:
>> - Fixed alignment issue
>> - Moved declarations and definitions
>> Since v5:
>> -Aesthetic changes
>> Since v6:
>> -Aesthetic changes introduced a compilation issue on some compilers
>> Since v7:
>> -Coding standards
>> Since v8:
>> -Fixed UBSan issues
>
> Re-tested as there a quite some changes, and also will re-ack it.
>
> Acked-by: Eelco Chaudron <[email protected]>
Thanks! Applied and backported to 3.0.
It might make sense to backport to 2.17 as well, but the patch
needs a significant rebase for that. Please, submit a backport
if the change is needed on 2.17.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
