Hi OVS family, I have been working on offloading only the exact-match flows in case of disable-megaflows. We observed that when the megaflows are disabled and we add a rule without any mask for any match field, then mf_set_value() function is called
In this function the mask values of all the match fields are set to UINT_XX_MAX which eventually populates the 'struct match'. When mask values of certain members of the 'struct match' are checked in the 'test_key_and_mask()' function (https://github.com/openvswitch/ovs/blob/e5d92c1a54852e9b5912aa53417d1f64bfee9af2/lib/netdev-offload-tc.c#L1536), if any one of them is non-NULL, the function will return 'EOPNOTSUPP' and the rule will not be offloaded to tc-flower. For now, I have just commented out the function 'test_key_and_mask()' and I am able to offload the exact match flows. My question is: Will this create any issue or am I breaking the functionality of the OVS? I have tested for few cases and I have seen the functionality is fine. Regards, Farhan Tariq, Software Engineer, DreamBig Semiconductor Inc. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
