Kevin Traynor, Jan 12, 2023 at 14:56: > > + (void) dpdk_cp_prot_rss_configure(dev, dev->up.n_rxq); > > I'm wondering is this needed? It is allowing traffic go to the extra > cp-proto queue that the user has not request for general traffic until > later when it is stopped. I don't see a need to use the extra queue > and I'm not sure that we should. e.g: > > # /root/ovs/utilities/ovs-vsctl set Interface myport options:n_rxq=4 > 2023-01-12T13:03:04Z|00175|netdev_dpdk|DBG|myport: cp-protection: reset flows > 2023-01-12T13:03:04Z|00176|netdev_dpdk|INFO|Port 0: 24:6e:96:71:fe:28 > 2023-01-12T13:03:04Z|00177|netdev_dpdk|INFO|myport: cp-protection: redirected > lacp traffic to rx queue 4 > 2023-01-12T13:03:04Z|00178|netdev_dpdk|INFO|myport: cp-protection: applied > rss on rx queue 0-3 > ... > # /root/ovs/utilities/ovs-vsctl remove interface myport options cp-protection > > 5368│ > 5369├> (void) dpdk_cp_prot_rss_configure(dev, dev->up.n_rxq); > 5370│ } > > dev->up.n_rxq = 5
This is weird, it should have been 4 when cp protection is disabled. I will have a closer look. > > + dev->requested_n_rxq = dev->user_n_rxq; > > + goto retry; > > A retry through this function is doing a double free on dev->tx > _q which gives an error message: > > 2023-01-12T12:27:13Z|00104|dpdk|ERR|EAL: Error: Invalid memory Indeed, I had missed that. I'll fix it for v8. Thanks. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
