Hi OVS family,

I have been working on offloading only the exact-match flows in case of 
disable-megaflows. When mask values of certain members of the 'struct match' 
are checked in the 'test_key_and_mask()' function 
(https://github.com/openvswitch/ovs/blob/e5d92c1a54852e9b5912aa53417d1f64bfee9af2/lib/netdev-offload-tc.c#L1536),
 if any one of them is non-NULL, the function will return 'EOPNOTSUPP' and the 
rule will not be offloaded to tc-flower.

For now, I have just commented out the function 'test_key_and_mask()' and I am 
able to offload the exact match flows.

My question is: If I don't comment this function and instead set the all the 
mask values of the flow (struct flow *mask) to 0, will this break OVS 
functionality. Are these mask values used anywhere else other than flow 
classification in case of megaflows disabled?


Regards,
Farhan Tariq,
Software Engineer,

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to