On 1/19/23 12:34, Ilya Maximets wrote:
> On 1/18/23 19:32, Dumitru Ceara wrote:
>> Recently OVS enabled AF_XDP support by default and that broke our RPM
>> build because of missing dependencies.
>>
>> Suggested-by: Ilya Maximets <[email protected]>
>> Signed-off-by: Dumitru Ceara <[email protected]>
>> ---
>> V2:
>> - Addressed Ilya's comments:
>>   - only install the minimal set of packages
>> - completely removed dnf clean as we don't really care about the builder
>>   image size.
>> ---
>>  .ci/ovn-kubernetes/Dockerfile | 15 ++++++---------
>>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> I think, this patch also needs a Fixes tag.
> 
> Fixes: 2ca0a4b8f2fe ("utilities: Do not send 'set-db-change-aware' for 
> non-daemon mode tools.")
> 
> Otherwise, the patch seem to work fine and looks good to me:
> 
> Acked-by: Ilya Maximets <[email protected]>
> 

Thanks, I added the tags and pushed it to main.

> Control plane tests are still failing, but it's not an issue
> of the current patch.  Someone needs to fix these tests though,
> because CI in its current form is kind of useless.
> 

I know, I already reached out on a different thread to ovnkube folks for
some help to investigate the failures.  I think it's just a setup issue
and I'd like to avoid just disabling tests if we can actually make them
pass.

I'll give it a few days before disabling the failing ones.

But thanks for reporting this!

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to