On 1/24/23 12:40, clevia...@marvell.com wrote:
> From: Chava Leviatan <clevia...@marvell.com>
>
> Tx queue are set each time port is added/removed or the cmask changes by
> reconfigure_datapath. The amount of TX queues is set according to PMD
> thread and does not take into consideration the device capabilities .
> As a result , when transmitting packet from OVS to device driver by
> rte_eth_tx_burst , the device driver is called with
> dev->data->tx_queues[queue_id] which is not a legal address , hence
> can cause a crash . This patch suggests to set the tx queue as a minimum
> between the device capability and the PMD thread number as requested
> by reconfigure_datapath.
> The patch was tested on Marvell setup include DPU running OVS-dpdk ,
> and Marvell DPDK Octeontx2 driver. DPU is bind to a host through PCI .
> Traffic is sent from associated host (VF) and remote host .
>
> Fixes: 050c60bfb5b4 ("netdev-dpdk: Use ->reconfigure() call to change rx/tx
> queues.")
>
> Reviewed-by: Liron Himi lir...@marvell.com
> Signed-off-by: Chava Leviatan <clevia...@marvell.com>
> ---
> lib/netdev-dpdk.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
This seems identical to the previous submission. I'm not sure
why it was sent twice.
Please, reply to comments for the previous submission:
https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401418.html
Marking this one as 'Changes Requested' for now.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
