While testing, I discovered some problems with drop sampling (first 4
patches).

Also, this series introduces an optimization. In order to avoid adding
sample actions on Chassis that do not have a Flow_Sample_Collector_Set
configured (which would generate a useless upcall), make the controller
monitor this table in OVS and recompute flows when it's changed.

The engine logic is pretty simple since this table is assumed to change
very rarely.

--
v1:
- Fixed commit message in patch 4.

Adrian Moreno (6):
  controller: fix recompute pflows if sampling changes
  northd: fix unsampled drops and unit test
  controller: add missing drop to loopback check table
  controller: set sampling port to OFP_NONE for drops
  controller: only sample flow if Collector Set exists
  controller: only sample pflow if Collector Set exists

 controller/lflow.c          |   1 +
 controller/lflow.h          |   8 +-
 controller/ovn-controller.c | 161 +++++++++++++++++++++++++++++-------
 controller/physical.c       |   2 +
 include/ovn/actions.h       |   4 +
 lib/actions.c               |   9 +-
 lib/ovn-util.c              |  51 ++++++++++++
 lib/ovn-util.h              |  26 +++++-
 northd/northd.c             |  17 ++--
 tests/ovn-performance.at    |  24 ++++++
 tests/ovn.at                |  15 +++-
 tests/test-ovn.c            |   9 ++
 12 files changed, 280 insertions(+), 47 deletions(-)

-- 
2.39.1

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to