On 1/26/23 22:14, Dumitru Ceara wrote: > Logical flow matches that always evaluate to false should never be > programmed by ovn-northd (or as ACLs). If that's the case, log a > warning. > > Note: matches that cannot be parsed because they refer to empty > or non existent port_groups/address_sets/templates don't generate > a valid expression structure so they trigger a different warning. > This behavior was already present before the current commit. >
Actually, this is not true and I currently don't see an easy way to differentiate between lflows that don't generate any match because they always evaluate to false and lflows that don't generate any match because they refer to port groups that currently don't include any local ports. That's why CI fails: https://github.com/ovsrobot/ovn/actions/runs/4019244469/jobs/6905842827#step:13:3813 2023-01-26T21:39:20.395Z|00035|lflow|WARN|lflow 72930e91-b98e-4641-90df-06d6cf420df4 match always evaluates to false: "reg0[10] == 1 && (inport == @pg1_drop && ip)" I'll abandon this patch for now, sorry for the noise. > Signed-off-by: Dumitru Ceara <[email protected]> > --- _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
