On 1/25/23 15:48, Eelco Chaudron wrote:
>
>
> On 25 Jan 2023, at 14:48, Ilya Maximets wrote:
>
>> UndefinedBehaviorSanitizer:
>>
>> lib/netdev-offload-tc.c:1356:50: runtime error:
>> member access within misaligned address 0x60700001a89c for type
>> 'const struct (unnamed struct at lib/netdev-offload-tc.c:1350:27)',
>> which requires 8 byte alignment 0x60700001a89c: note: pointer points here
>> 24 00 04 00 01 00 00 05 00 00 0d 00 0a 00 00 00 00 00 00 00 ...
>> ^
>> 0 0xd5d183 in parse_put_flow_ct_action lib/netdev-offload-tc.c:1356:50
>> 1 0xd5783f in netdev_tc_parse_nl_actions lib/netdev-offload-tc.c:2015:19
>> 2 0xd4027c in netdev_tc_flow_put lib/netdev-offload-tc.c:2355:11
>> 3 0x9666d7 in netdev_flow_put lib/netdev-offload.c:318:14
>> 4 0xcd4c0a in parse_flow_put lib/dpif-netlink.c:2297:11
>> 5 0xcd4c0a in try_send_to_netdev lib/dpif-netlink.c:2384:15
>> 6 0xcd4c0a in dpif_netlink_operate lib/dpif-netlink.c:2455:23
>> 7 0x87d40e in dpif_operate lib/dpif.c:1372:13
>> 8 0x6d43e9 in handle_upcalls ofproto/ofproto-dpif-upcall.c:1674:5
>> 9 0x6d43e9 in recv_upcalls ofproto/ofproto-dpif-upcall.c:905:9
>> 10 0x6cf6ea in udpif_upcall_handler ofproto/ofproto-dpif-upcall.c:801:13
>> 11 0xb6d7ea in ovsthread_wrapper lib/ovs-thread.c:423:12
>> 12 0x7f5ccf017801 in start_thread
>> 13 0x7f5ccefb744f in __GI___clone3
>>
>> Fixes: 9221c721bec0 ("netdev-offload-tc: Add conntrack label and mark
>> support")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> The changes look good to me.
>
> Acked-by: Eelco Chaudron <[email protected]>
>
Thanks, Eelco and Simon!
Applied and backported down to 2.17.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
