On 1/3/23 14:36, Eelco Chaudron wrote: > Depending on the driver implementation it can take up to 2 seconds before > offloaded flow statistics are updated. This is causing a problem with > min-revalidate-pps, as old statistic values are used during this period. > > This fix will wait for at least 2 seconds before assuming no packets > where received during this period. > > Signed-off-by: Eelco Chaudron <[email protected]> > --- > > Changes: > - v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is > also covered. > - v3: Added OVS_REQUIRES(ukey->mutex) to should_revalidate() to keep > thread-safety-analysis happy. > > ofproto/ofproto-dpif-upcall.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-)
Just leaving a note here for consistency: the main discussion around this change and the root cause of the issue is happening in v2 thread: https://patchwork.ozlabs.org/project/openvswitch/patch/167274555298.379205.1390528419336184506.stgit@ebuild/ Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
