On 1/29/23 09:18, Roi Dayan wrote:
>
>
> On 27/01/2023 13:16, Eelco Chaudron wrote:
>> A long long time ago, an effort was made to make tc flower
>> rtnl_lock() free. However, on the OVS part we forgot to add
>> the TCA_KIND "flower" attribute, which tell the kernel to skip
>> the lock. This patch corrects this by adding the attribute for
>> the delete and get operations.
>>
>> The kernel code calls tcf_proto_is_unlocked() to determine the
>> rtnl_lock() is needed for the specific tc protocol. It does this
>> in the tc_new_tfilter(), tc_del_tfilter(), and in tc_get_tfilter().
>>
>> If the name is not set, tcf_proto_is_unlocked() will always return
>> false. If set, the specific protocol is queried for unlocked support.
>>
>> Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
> thanks. looks good.
> Did few ovs tc tests to verify all good.
>
> Reviewed-by: Roi Dayan <[email protected]>
Thanks! Applied and backported down to 2.17.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
