On 2/1/23 07:33, [email protected] wrote: > From: eddytaoyuan <[email protected]> > > 'struct cpumask cpu_used_mask' is embedded in struct sw_flow. > However, its size is hardcoded to CONFIG_NR_CPUS bits, which can be > 8192 by default, it costs memory and slows down ovs_flow_alloc. > This fix uses actual CPU number instead > > This submission is for 2.17 LTS only. > > Since datapath has been moved to linux kernel since 3.0, I will file > seperate review to kernel community in another thread
Hi. Thanks for the patch! According to our process [1], kernel datapath patches should be accepted to the upstream kernel first. After that they can be backported to the kernel module in the OVS tree. However, the datapath implementation, that still exists in branch 2.17, is deprecated, so we do not accept changes aside from critical bug fixes. Your change seems to be a performance optimization and not a bug fix. Also, fixes should be backported in the order they appear in the upstream kernel, and we're currently missing a few. Note: for the future, patches for branch-2.17 should have 'branch-2.17' in the subject prefix, i.e. '[PATCH branch-2.17]'. This way CI bots will know where to apply them. And backports should have a specific format described in [1]. [1] https://docs.openvswitch.org/en/latest/internals/contributing/backporting-patches/#changes-to-linux-kernel-components Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
