On Wed, Feb 01, 2023 at 07:28:09PM +0300, Fedor Pchelkin wrote: > On 2/1/23 6:45 PM, Simon Horman wrote: > > I see this would work by virtue of kfree(key) doing nothing > > of key is NULL, the error case in question. And that otherwise key is > > non-NULL if this path is hit. > > > > However, the idiomatic approach to error handling is for the error path > > to unwind resource allocations in the reverse order that they were made. > > And for goto labels to control how far to unwind. > > > > You are right, thanks. Have to keep 'goto' structured, otherwise there > would be a 'goto' mess. > > > So I think the following would be more in keeping with the intention of the > > code. Even if it is a somewhat more verbose change. > > > > *compile tested only!* > > I'll test this on error paths and resend the patch.
Thanks, much appreciated. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
