I commented the three remaining failures when running tc with the
system-traffic tests. In addition I ran the following test to verify
we did not see any failures with recheck enabled:
for i in {1..50}; do make check-offloads || \
make check-offloads TESTSUITEFLAGS="--recheck" || break; \
echo "ALL_50_OK: $i"; done;
Unfortunately, a bunch of test cases showed occasional failures.
For now, they are excluded from the test cases and need further
investigation. They are:
datapath - truncate and output to gre tunnel
datapath - truncate and output to gre tunnel by simulated packets
These tests where executed on a Fedora37 machine with the kernel
6.1.5-200.fc37.x86_64 installed.
Signed-off-by: Eelco Chaudron <[email protected]>
Acked-by: Roi Dayan <[email protected]>
---
tests/system-offloads-testsuite-macros.at | 21 +++++++++++++++++++++
tests/system-traffic.at | 2 ++
2 files changed, 23 insertions(+)
diff --git a/tests/system-offloads-testsuite-macros.at
b/tests/system-offloads-testsuite-macros.at
index 322166b8c..e50dc07fb 100644
--- a/tests/system-offloads-testsuite-macros.at
+++ b/tests/system-offloads-testsuite-macros.at
@@ -30,6 +30,27 @@ m4_define([OVS_TRAFFIC_VSWITCHD_START],
])
# Macro to exclude tests that will fail with TC offload enabled.
+# We currently have the below tests disabled in system-traffic.at
+# for the following reasons:
+#
+# TC does not support moving ports to a different namespace than vswitchd's
+# namespace, so we need to disable this test.
+# - 'conntrack - multiple namespaces, internal ports'
+#
+# The kernel's tcf_ct_act() function does not seem to take care of any (QinQ)
+# VLAN headers causing commits to fail. However, if this is solved, we have to
+# make sure conntrack does not break the VLAN boundary, i.e., putting together
+# two packets with different CVLAN+SVLAN values.
+# - 'conntrack - IPv4 fragmentation + cvlan'
+#
+# Fragmentation handling in ct zone 9 does not seem to work correctly.
+# When moving this test over to the default zone all works fine.
+# - 'conntrack - Fragmentation over vxlan'
+#
+# Occasionally we fail with invalid byte counts.
+# - 'datapath - truncate and output to gre tunnel by simulated packets'
+# - 'datapath - truncate and output to gre tunnel'
+#
m4_define([CHECK_NO_TC_OFFLOAD],
[
AT_SKIP_IF([:])
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index ba95c2614..c61be644f 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -1639,6 +1639,7 @@ dnl ns0: connect to br-underlay, with IP: 10.1.1.1
AT_SETUP([datapath - truncate and output to gre tunnel by simulated packets])
OVS_CHECK_MIN_KERNEL(3, 10)
AT_SKIP_IF([test $HAVE_NC = no])
+CHECK_NO_TC_OFFLOAD()
OVS_TRAFFIC_VSWITCHD_START()
ADD_BR([br-underlay], [set bridge br-underlay
other-config:hwaddr=\"02:90:8c:a8:a1:49\"])
@@ -1770,6 +1771,7 @@ AT_SETUP([datapath - truncate and output to gre tunnel])
AT_SKIP_IF([test $HAVE_NC = no])
OVS_CHECK_KERNEL_EXCL(3, 10, 4, 15)
OVS_CHECK_GRE()
+CHECK_NO_TC_OFFLOAD()
OVS_TRAFFIC_VSWITCHD_START()
ADD_BR([br-underlay])
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
