On 2/3/23 01:43, Han Zhou wrote: > On Thu, Feb 2, 2023 at 11:51 AM Dumitru Ceara <[email protected]> wrote: >> >> On 2/2/23 01:30, Han Zhou wrote: >>> In ovn_igmp_group_get_ports(), it accesses a union member that should >>> exist only if the port is a LSP: port->peer->od->mcast_info.rtr.relay. >>> But in theory it is possible that the "port" is in fact a LRP, because >>> it is a result of ovn_port_find() with the port name coming from a SB DB >>> entry. So it is better to validate that first. >>> >>> Signed-off-by: Han Zhou <[email protected]> >>> --- >> >> Good catch, thanks for the fix! >> >> Acked-by: Dumitru Ceara <[email protected]> >> >> Do you think it's worth backporting this? >> > Thanks Dumitru! > The problem is not easy to be triggered, but the change is small and it > doesn't harm to backport. So, I applied to main and backported down to > 22.03. >
Cool, thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
