On 2023/02/10 20:28, Eelco Chaudron wrote:
> On 7 Feb 2023, at 7:48, Nobuhiro MIKI wrote:
> 
>> We can use the "ip route add ... src ..." command to set the preferred
>> source address for each entry in the kernel FIB. OVS has a mechanism to
>> cache the FIB, but the preferred source address is ignored and
>> calculated with its own logic. This patch resolves the difference
>> between kernel FIB and OVS route table cache by retrieving the
>> RTA_PREFSRC attribute of Netlink messages.
> 
> Thanks for the patch, one small nit inline, the rest looks good.
> 
> Cheers,
> 
> Eelco

Hi,

Thanks for your review.

Best Regards,
Nobuhiro MIKI

>>          [RTA_OIF] = { .type = NL_A_U32, .optional = true },
>>          [RTA_GATEWAY] = { .type = NL_A_U32, .optional = true },
>>          [RTA_MARK] = { .type = NL_A_U32, .optional = true },
>> +        [RTA_PREFSRC] = { .type = NL_A_U32, .optional = true  },
> 
> You have a double space after true and before }.

OK. Thanks.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to