> -----Original Message-----
> From: Robin Jarry <[email protected] <mailto:[email protected]>>
> Date: Thursday 23 February 2023 at 22:14
> To: Aaron Conole <[email protected] <mailto:[email protected]>>
> Cc: "[email protected] <mailto:[email protected]>"
> <[email protected] <mailto:[email protected]>>, Eli Britstein
> <[email protected] <mailto:[email protected]>>, Gaetan Rivet
> <[email protected] <mailto:[email protected]>>, Ilya Maximets
> <[email protected] <mailto:i. [email protected]>>, Maxime Coquelin
> <[email protected] <mailto:[email protected]>>, Jason
> Gunthorpe <[email protected] <mailto:[email protected]>>, Majd Dibbiny
> <[email protected] <mailto:[email protected]>>, David Marchand
> <[email protected] <mailto:[email protected]>>, Gaetan Rivet
> <[email protected] <mailto:[email protected]>>, Eelco Chaudron <[email protected]
> <mailto:[email protected]>>
> Subject: Re: [ovs-dev] [RFC] dpdk: Allow retaining cap_sys_rawio privileges
>
>
> External email: Use caution opening links or attachments
>
>
>
>
> Aaron Conole, Feb 23, 2023 at 22:09:
> > Thanks for taking a look. You're saying that you tested without this
> > patch applied, yes? That could be. I only know of one hardware which
> > requires CAP_SYS_RAWIO for rte_flow to function.
>
>
> Yes that is correct, I tested *without* this patch applied and with
> a non-root user (ovs-vswitchd linked with libcap-ng).
>
>
> ovs-ctl --ovs-user="openvswitch:hugetlbfs" start
>
>
> The basic RTE flow rules (matching of the ether type field and redirect
> to a specific queue) were created without errors returned with both NICs
> I had available (Intel X710 and Mellanox ConnectX-5 Ex)
>
>
> cp-protection: redirected lacp traffic to rx queue 1
> cp-protection: redirected other traffic to rx queue 0
Hello,
I've looked at your patch Robin and the offloads you insert in
dpdk_cp_prot_add_flow
use the following:
const struct rte_flow_attr attr = { .ingress = 1 };
implicitly setting transfer and group to 0. If either of those had been
non-zero instead,
cap_sys_rawio would be required.
Otherwise thank you very much Aaron for you patch, I was reading it and will
comment directly to it.
Best regards,
Gaetan
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev