On 23 Feb 2023, at 12:26, Chris Mi wrote:
> v2-v1: > - Fix robot errors. > v3-v2: > - Remove Gerrit Change-Id. > - Add patch #9 to fix older kernels build issue. > - Add travis test result. > v4-v3: > - Fix offload issue when sampling rate is 1. > v5-v4: > - Move polling thread from ofproto to netdev-offload-tc. > v6-v5: > - Rebase. > - Add GitHub Actions test result. > v7-v6: > - Remove Gerrit Change-Id. > - Fix "ERROR: Inappropriate spacing around cast" > v8-v7 > - Address Eelco Chaudron's comment for patch #11. > v9-v8 > - Remove sflow_len from struct dpif_sflow_attr. > - Log a debug message for other userspace actions. > v10-v9 > - Address Eelco Chaudron's comments on v9. > v11-v10 > - Fix a bracing error. > v12-v11 > - Add duplicate sample group id check. > v13-v12 > - Remove the psample poll thread from netdev-offload-tc and reuse > ofproto handler thread according to Ilya's new desgin. > - Add dpif-offload-provider layer according to Eli's suggestion. > v14-v13 > - Fix a robot error. > v15-v14 > - Address Eelco Chaudron's comments on v14. > v16-v15 > - Address Eelco Chaudron's comments on v15. > - Add two test cases. > v17-v16 > - Address Eelco Chaudron's comments on v16. > - Move struct dpif_offload_api from struct dpif_class to struct dpif. > v18-v17 > - Rename dpif_offload_api to dpif_offload_class. > - Add init and destroy callbacks in dpif_offload_class. They are called > when registering dpif_offload_class. > v19-18 > - Fix a bug that psample_sock is destroyed when last bridge is deleted. > v20-19 > - Move buf_stub to struct dpif_offload_sflow avoid garbage values when > ofproto proceses the sampled packet. > v21-20 > - Remove netdev dummy for dpif-offload according to Eelco's comment. > v22-21 > - Address Ilya's comments: > - Remove dpif-offload-provider layer. > - Remove process_offload_sflow and reuse upcall_receive. > - Introduce sample id pool. > - Introduce netdev_offload_recv. > > Chris Mi (8): > compat: Add psample and tc sample action defines for older kernels > ovs-kmod-ctl: Load kernel module psample > netdev-offload-tc: Introduce group ID management API > netdev-offload-tc: Add sFlow offload API for TC > netdev-offload: Add netdev offload recv and recv_wait APIs > dpif-netlink: Add netdev offload recv in normal recv upcalls > netdev-offload-tc: Add offload support for sFlow > system-offloads-traffic.at: Add sFlow offload test cases > > include/linux/automake.mk | 4 +- > include/linux/psample.h | 62 +++ > include/linux/tc_act/tc_sample.h | 25 ++ > lib/dpif-netlink.c | 46 ++- > lib/dpif.h | 7 + > lib/netdev-offload-provider.h | 11 + > lib/netdev-offload-tc.c | 647 ++++++++++++++++++++++++++++++- > lib/netdev-offload.c | 32 ++ > lib/netdev-offload.h | 13 + > lib/tc.c | 62 ++- > lib/tc.h | 12 +- > ofproto/ofproto-dpif-upcall.c | 23 +- > tests/system-offloads-traffic.at | 101 +++++ > utilities/ovs-kmod-ctl.in | 14 + > 14 files changed, 1036 insertions(+), 23 deletions(-) > create mode 100644 include/linux/psample.h > create mode 100644 include/linux/tc_act/tc_sample.h As I was on PTO last week, and in addition, I see a lot of comments already from Ilya, I’ll wait for the next revision before doing another full review. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
