On Mon, Feb 27, 2023 at 02:08:25PM +0100, Eelco Chaudron wrote:
>
>
> On 22 Feb 2023, at 13:46, Simon Horman wrote:
>
> > On Wed, Feb 22, 2023 at 12:30:17PM +0200, Roi Dayan via dev wrote:
> >> Sometimes there is a need to clean empty chains as done in
> >> delete_chains_from_netdev(). The cited commit doesn't remove
> >> the chain completely which cause adding ingress_block later to fail.
> >> This can be reproduced with adding bond as ovs port which makes ovs
> >> use ingress_block for it.
> >> While at it add the netdev name that fails to the log.
> >>
> >> Fixes: e1e5eac5b016 ("tc: Add TCA_KIND flower to delete and get operation
> >> to avoid rtnl_lock().")
> >> Signed-off-by: Roi Dayan <[email protected]>
> >
> > I think this needs an ack from Eelco (CCed).
> >
> > But it looks good to me.
> >
> > Reviewed-by: Simon Horman <[email protected]>
>
> The changes look good to me. Will it be worth adding a test case?
>From my POV, yes, I think that would be nice.
Roi, do you have any thoughts on this?
> Acked-by: Eelco Chaudron <[email protected]>
...
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
