On Wed, Mar 1, 2023 at 3:47 PM Simon Horman <simon.hor...@corigine.com> wrote:
> On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote: > > Newer versions of ping6 print some info to > > stderr when specified with -v flag. This info > > causes tests to fail. Do not use the verbose > > output. > > > > Signed-off-by: Ales Musil <amu...@redhat.com> > > I think it would be useful to describe the difference in the ping6 output, > and possibly how it breaks things. > > I for one am unsure and thus am having trouble reviewing the > correctness of this patch. > Sure, I'll add it to the commit message in v3. Thanks, Ales > > > --- > > tests/system-ovn.at | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > > index 563858e70..07884dfbe 100644 > > --- a/tests/system-ovn.at > > +++ b/tests/system-ovn.at > > @@ -285,7 +285,7 @@ ovn-nbctl --wait=hv sync > > OVS_WAIT_UNTIL([ovs-ofctl dump-flows br-int | grep 'nat(src=fd30::1)']) > > > > # 'alice1' should be able to ping 'foo1' directly. > > -NS_CHECK_EXEC([alice1], [ping6 -v -q -c 3 -i 0.3 -w 2 fd11::2 | > FORMAT_PING], \ > > +NS_CHECK_EXEC([alice1], [ping6 -q -c 3 -i 0.3 -w 2 fd11::2 | > FORMAT_PING], \ > > [0], [dnl > > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > > ]) > > @@ -8497,7 +8497,7 @@ NS_CHECK_EXEC([ls1p1], [ping -q -c 3 -i 0.3 -w 2 > 172.16.1.1 | FORMAT_PING], \ > > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > > ]) > > > > -NS_CHECK_EXEC([ls1p1], [ping6 -v -q -c 3 -i 0.3 -w 2 1711::1 | > FORMAT_PING], \ > > +NS_CHECK_EXEC([ls1p1], [ping6 -q -c 3 -i 0.3 -w 2 1711::1 | > FORMAT_PING], \ > > [0], [dnl > > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > > ]) > > -- > > 2.39.1 > > > > _______________________________________________ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> amu...@redhat.com IM: amusil <https://red.ht/sig> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
