On 2/24/23 12:01, Felix Hüttner via dev wrote: > the comments did refer to tables 1 below the actual table number. > > Signed-off-by: Felix Huettner <[email protected]> > --- > northd/northd.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/northd/northd.c b/northd/northd.c > index 770a5b50e..c366b545e 100644 > --- a/northd/northd.c > +++ b/northd/northd.c > @@ -7856,7 +7856,7 @@ build_lrouter_groups(struct hmap *ports, struct > ovs_list *lr_list) > } > > /* > - * Ingress table 24: Flows that flood self originated ARP/RARP/ND packets in > + * Ingress table 25: Flows that flood self originated ARP/RARP/ND packets in > * the switching domain. > */ > static void > @@ -7970,7 +7970,7 @@ lrouter_port_ipv6_reachable(const struct ovn_port *op, > } > > /* > - * Ingress table 24: Flows that forward ARP/ND requests only to the routers > + * Ingress table 25: Flows that forward ARP/ND requests only to the routers > * that own the addresses. Other ARP/ND packets are still flooded in the > * switching domain as regular broadcast. > */ > @@ -8007,7 +8007,7 @@ build_lswitch_rport_arp_req_flow(const char *ips, > } > > /* > - * Ingress table 24: Flows that forward ARP/ND requests only to the routers > + * Ingress table 25: Flows that forward ARP/ND requests only to the routers > * that own the addresses. > * Priorities: > * - 80: self originated GARPs that need to follow regular processing. > @@ -8336,7 +8336,7 @@ build_lswitch_flows(const struct hmap *datapaths, > > struct ovn_datapath *od; > > - /* Ingress table 25: Destination lookup for unknown MACs (priority 0). */ > + /* Ingress table 25/26: Destination lookup for unknown MACs (priority > 0). */ > HMAP_FOR_EACH (od, key_node, datapaths) { > if (!od->nbs) { > continue; > @@ -8411,7 +8411,7 @@ build_lswitch_lflows_admission_control(struct > ovn_datapath *od, > } > } > > -/* Ingress table 18: ARP/ND responder, skip requests coming from localnet > +/* Ingress table 98: ARP/ND responder, skip requests coming from localnet
I guess you meant 19 here. :) I fixed that and applied the patch to the main branch and backported it down to 22.12 (for older branches we need different versions of this patch but I don't think that's too urgent). I also added you to the AUTHORS.rst file. I see you already have some older contributions but somehow we forgot to add you to the list. Sorry about that! Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
