On 6 Mar 2023, at 3:49, Nobuhiro MIKI wrote:

> When adding a route with ovs/route/add command, the source address
> in "ovs_router_entry" structure is always the FIRST address that the
> interface has. See "ovs_router_get_netdev_source_address"
> function for more information.
>
> If an interface has multiple ipv4 and/or ipv6 addresses, there are use
> cases where the user wants to control the source address. This patch
> therefore addresses this issue by adding a src parameter.
>
> Note that same constraints also exist when caching routes from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Acked-by: Eelco Chaudron <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>
> Signed-off-by: Nobuhiro MIKI <[email protected]>
> ---
>  NEWS                            |  3 ++
>  lib/ovs-router.c                | 86 +++++++++++++++++++++++++++++----
>  ofproto/ofproto-tnl-unixctl.man |  5 +-
>  tests/ovs-router.at             | 80 +++++++++++++++++++++++++++++-
>  4 files changed, 161 insertions(+), 13 deletions(-)

Changes look good to me! ACKing additional test script changes due to suggested 
message changes.

Acked-by: Eelco Chaudron <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to