On Tue, Mar 7, 2023 at 12:38 AM Ales Musil <[email protected]> wrote:
>
>
>
> On Thu, Feb 23, 2023 at 7:35 AM Han Zhou <[email protected]> wrote:
>>
>> Han Zhou (3):
>> ovn.at: Fix virtual port tests.
>> system-ovn.at: Add system test for virtual port with floating IP.
>> northd: Use dynamic mac-binding for virtual port IPs.
>>
>> northd/northd.c | 103 ----------------------------
>> northd/ovn-northd.8.xml | 37 ++--------
>> tests/atlocal.in | 3 +
>> tests/ovn.at | 64 +++---------------
>> tests/system-ovn.at | 145 ++++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 163 insertions(+), 189 deletions(-)
>>
>> --
>> 2.30.2
>>
>> _______________________________________________
>> dev mailing list
>> [email protected]
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>
> The whole series looks good to me, thanks.
>
> Acked-by: Ales Musil <[email protected]>
>
Thanks Ales for reviewing.
Also thanks Simon for reviewing and testing.
I incorporated the minor change for patch 2 below (verified by Simon), also
added some description in patch 2 commit message, and pushed the series to
main.
Thanks,
Han
-----------------------------------------------------------------------------------
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 92c32087ee23..03dd08ad81dc 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -10797,7 +10797,7 @@ ADD_VETH(ln1, ns_ext1, br-ex, "172.0.0.99/24",
"0a:0a:b6:fc:03:01", "172.0.0.1")
NS_CHECK_EXEC([ns_ls1p1], [ip addr del 10.0.0.11/24 dev ls1p1;
ip addr add 10.0.0.88/24 dev ls1p1;
ip route add default via 10.0.0.1])
-NS_EXEC([ns_ls1p1], [arping -U -c 1 -w 2 -I ls1p1 -s 10.0.0.88 10.0.0.88])
+NS_EXEC([ns_ls1p1], [arping -U -c 1 -w 2 -I ls1p1 10.0.0.88])
wait_for_ports_up vip
check ovn-nbctl --wait=hv sync
@@ -10818,7 +10818,7 @@ NS_CHECK_EXEC([ns_ls1p1], [ip addr del 10.0.0.88/24
dev ls1p1])
NS_CHECK_EXEC([ns_ls1p2], [ip addr del 10.0.0.12/24 dev ls1p2;
ip addr add 10.0.0.88/24 dev ls1p2;
ip route add default via 10.0.0.1])
-NS_EXEC([ns_ls1p2], [arping -U -c 1 -w 2 -I ls1p2 -s 10.0.0.88 10.0.0.88])
+NS_EXEC([ns_ls1p2], [arping -U -c 1 -w 2 -I ls1p2 10.0.0.88])
wait_column "ls1p2" Port_Binding virtual_parent logical_port=vip
check ovn-nbctl --wait=hv sync
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
