On 8 Mar 2023, at 13:53, Ilya Maximets wrote:
> On 3/8/23 13:23, Eelco Chaudron wrote: >> Depending on the driver implementation, it can take from 0.2 seconds >> up to 2 seconds before offloaded flow statistics are updated. This is >> true for both TC and rte_flow-based offloading. This is causing a >> problem with min-revalidate-pps, as old statistic values are used >> during this period. >> >> This fix will wait for at least 2 seconds, by default, before assuming no >> packets where received during this period. >> >> Reviewed-by: Simon Horman <[email protected]> >> Signed-off-by: Eelco Chaudron <[email protected]> >> --- >> >> Changes: >> - v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is >> also covered. >> - v3: Added OVS_REQUIRES(ukey->mutex) to should_revalidate() to keep >> thread-safety-analysis happy. >> - v4: Add a configurable option. >> After looking at multiple vendor implementation for both TC and >> rte_flow I came to the conclusion that the delay is roughly between >> 0.2 and 2 seconds. Updated commit message. >> - v5: Rebased on latest upstream master. >> Made the key parameter const in should_revalidate(). >> - v6: Updated comments and documentation to be more clear. >> >> ofproto/ofproto-dpif-upcall.c | 26 ++++++++++++++++---------- >> ofproto/ofproto-provider.h | 5 +++++ >> ofproto/ofproto.c | 10 ++++++++++ >> ofproto/ofproto.h | 2 ++ >> vswitchd/bridge.c | 3 +++ >> vswitchd/vswitch.xml | 13 +++++++++++++ >> 6 files changed, 49 insertions(+), 10 deletions(-) > > Hi, Eelco. This patch is not applicable to current master. > Needs a rebase. Yes, the robot just told me ;) A v7 is out right now… //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
