On Thu, Mar 9, 2023 at 1:15 PM Ilya Maximets <[email protected]> wrote:

> On 3/6/23 14:37, Ales Musil wrote:
> > Signed-off-by: Ales Musil <[email protected]>
>
> Needs a Fixes tag.
>
> > ---
> >  vswitchd/vswitch.xml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> > index 12708a313..15e4f97b7 100644
> > --- a/vswitchd/vswitch.xml
> > +++ b/vswitchd/vswitch.xml
> > @@ -6301,6 +6301,11 @@ ovs-vsctl add-port br0 p0 -- set Interface p0
> type=patch options:peer=p1 \
> >          translated to an ephemeral port. If there is no collision, no
> SNAT
> >          is performed.
> >        </column>
> > +      <column name="capabilities" key="ct_flush"
> > +              type='{"type": "boolean"}'>
> > +        True if the datapath supports CT flush extension. The extensions
> > +        allows to flush CT entries based on specified parameters.
>
> This doesn't really describe the capability.  It was possible to flush
> conntrack based on the zone in the past.  That matches the description,
> but doesn't match the intent behind the capability flag.  You probably
> should mention how this capability relates to the new OpenFlow request.
>
> Best regards, Ilya Maximets.
>
>
I've made the relation with the extension more explicit in v3.

Thanks,
Ales

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA <https://www.redhat.com>

[email protected]    IM: amusil
<https://red.ht/sig>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to