Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#231 FILE: lib/dpctl.c:470:
dpctl_error(dpctl_p, 0, "%s: can't change port number
from"
WARNING: Line is 80 characters long (recommended limit is 79)
#232 FILE: lib/dpctl.c:471:
" %"PRIu32" to %d", name, port_no, atoi(value));
WARNING: Line is 80 characters long (recommended limit is 79)
#502 FILE: lib/odp-execute.c:184:
nh->ip_csum = recalc_csum16(nh->ip_csum, htons(nh->ip_ttl << 8),
WARNING: Line is 96 characters long (recommended limit is 79)
#617 FILE: lib/sflow_agent.c:158:
/* add to end of list - to preserve the receiver index numbers for
existing receivers */
ERROR: Improper whitespace around control block
#620 FILE: lib/sflow_agent.c:161:
for(r = agent->receivers; r != NULL; prev = r, r = r->nxt);
ERROR: Improper whitespace around control block
#621 FILE: lib/sflow_agent.c:162:
if(prev) prev->nxt = rcv;
ERROR: Inappropriate spacing around cast
#649 FILE: lib/sflow_agent.c:208:
SFLSampler *newsm = (SFLSampler *)sflAlloc(agent, sizeof(SFLSampler));
ERROR: Improper whitespace around control block
#653 FILE: lib/sflow_agent.c:212:
if(prev) prev->nxt = newsm;
WARNING: Line is 98 characters long (recommended limit is 79)
#659 FILE: lib/sflow_agent.c:218:
SFLSampler *test = sfl_agent_getSamplerByIfIndex(agent,
SFL_DS_INDEX(newsm->dsi));
WARNING: Line is 89 characters long (recommended limit is 79)
#660 FILE: lib/sflow_agent.c:219:
if (test && (SFL_DS_INSTANCE(newsm->dsi) <
SFL_DS_INSTANCE(test->dsi))) {
WARNING: Line is 93 characters long (recommended limit is 79)
#661 FILE: lib/sflow_agent.c:220:
/* replace with this new one because it has a lower
ds_instance number */
ERROR: Inappropriate bracing around statement
#665 FILE: lib/sflow_agent.c:224:
if (test == NULL) sfl_agent_jumpTableAdd(agent, newsm);
ERROR: Inappropriate spacing around cast
#682 FILE: lib/sflow_agent.c:249:
SFLPoller *newpl = (SFLPoller *)sflAlloc(agent, sizeof(SFLPoller));
ERROR: Inappropriate bracing around statement
#686 FILE: lib/sflow_agent.c:253:
if (prev) prev->nxt = newpl;
WARNING: Line is 83 characters long (recommended limit is 79)
#774 FILE: ovsdb/file.c:543:
json_object_put(ftxn->json, table->schema->name,
ftxn->table_json);
WARNING: Line is 101 characters long (recommended limit is 79)
#947 FILE: ovsdb/ovsdb-client.c:1237:
const struct ovsdb_column *version_column =
ovsdb_table_schema_get_column(table, "_version");
WARNING: Line is 82 characters long (recommended limit is 79)
#1079 FILE: ovsdb/ovsdb.c:222:
return ovsdb_syntax_error(json, NULL, "schema version \"%s\"
not "
WARNING: Line is 82 characters long (recommended limit is 79)
#1104 FILE: ovsdb/ovsdb.c:239:
error = ovsdb_syntax_error(json, NULL, "name must be a valid
id");
WARNING: Line is 82 characters long (recommended limit is 79)
#1142 FILE: ovsdb/ovsdb.c:256:
/* "isRoot" was not part of the original schema definition. Before it
was
WARNING: Line is 81 characters long (recommended limit is 79)
#1144 FILE: ovsdb/ovsdb.c:258:
* compatibility, if the root set is empty then assume that every table
is
WARNING: Line is 82 characters long (recommended limit is 79)
#1166 FILE: ovsdb/ovsdb.c:271:
* ovsdb_schema_check_ref_table(). This requires 'is_root' to be known,
so
WARNING: Line is 81 characters long (recommended limit is 79)
#1189 FILE: ovsdb/ovsdb.c:283:
error = ovsdb_schema_check_ref_table(column,
&schema->tables,
WARNING: Line is 80 characters long (recommended limit is 79)
#1309 FILE: utilities/ovs-vsctl.c:339:
ctl_fatal("value %s on -t or --timeout is invalid", optarg);
WARNING: Line is 80 characters long (recommended limit is 79)
#1418 FILE: utilities/ovs-vsctl.c:842:
VLOG_WARN("%s: port is in multiple bridges (%s and %s)",
WARNING: Line is 82 characters long (recommended limit is 79)
#1426 FILE: utilities/ovs-vsctl.c:846:
* uniqueness constraints, so the database server
shouldn't
WARNING: Line is 85 characters long (recommended limit is 79)
#1443 FILE: utilities/ovs-vsctl.c:862:
struct ovsrec_interface *iface_cfg =
port_cfg->interfaces[k];
WARNING: Line is 85 characters long (recommended limit is 79)
#1446 FILE: utilities/ovs-vsctl.c:865:
iface = shash_find_data(&vsctl_ctx->ifaces,
iface_cfg->name);
WARNING: Line is 87 characters long (recommended limit is 79)
#1455 FILE: utilities/ovs-vsctl.c:874:
/* Log as an error because this violates the
database's
WARNING: Line is 80 characters long (recommended limit is 79)
#1456 FILE: utilities/ovs-vsctl.c:875:
* uniqueness constraints, so the database server
WARNING: Line is 85 characters long (recommended limit is 79)
#1458 FILE: utilities/ovs-vsctl.c:877:
VLOG_ERR("%s: database contains duplicate
interface "
WARNING: Line is 84 characters long (recommended limit is 79)
#1492 FILE: utilities/ovs-vsctl.c:918:
ctl_fatal("%s because an interface named %s already exists", msg,
name);
WARNING: Line is 83 characters long (recommended limit is 79)
#1511 FILE: utilities/ovs-vsctl.c:977:
if (iface && iface->port->bridge && !strcmp(name,
iface->port->bridge->name)) {
WARNING: Line is 80 characters long (recommended limit is 79)
#1550 FILE: vtep/vtep-ctl.c:255:
ctl_fatal("value %s on -t or --timeout is invalid", optarg);
WARNING: Line is 82 characters long (recommended limit is 79)
#1590 FILE: vtep/vtep-ctl.c:1085:
* uniqueness constraints, so the database server
shouldn't
WARNING: Line is 84 characters long (recommended limit is 79)
#1610 FILE: vtep/vtep-ctl.c:1099:
vlan = xasprintf("%"PRId64,
port_cfg->key_vlan_bindings[k]);
Lines checked: 1648, Warnings: 28, Errors: 7
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
