On 3/16/23 10:13, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> Initialize psample socket. Add sFlow recv API to receive sampled
>> packets from psample socket. Add sFow recv wait API to add psample
>> socket fd to poll list.
>
> See some comments inline below. and one question for Ilya ;)
>
> //Eelco
>
>> Signed-off-by: Chris Mi <c...@nvidia.com>
>> Reviewed-by: Roi Dayan <r...@nvidia.com>
>> ---
>> lib/dpif.h | 2 +
>> lib/netdev-offload-provider.h | 14 +++
>> lib/netdev-offload-tc.c | 201 ++++++++++++++++++++++++++++++++++
>> 3 files changed, 217 insertions(+)
>>
<snip>
>>
>> +static void
>> +psample_init(void)
>> +{
>> + unsigned int psample_mcgroup;
>> + int err;
>> +
>> + if (!netdev_is_flow_api_enabled()) {
>> + VLOG_DBG("Flow API is not enabled.");
>
> I think for logs we do not need dots at the end. Ilya what is the general
> rule? In this file, most logs do not have a . at the end.
Unlike comments, we're a bit inconsistent on the logs. Some logs do have
periods, some do not. For now, I'd suggest to just stick to whatever other
existing logs in that module are using.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
