No, my usecase with 2.17 is that I just want to check agains a running process wether memory compaction is enabled or not without searching specific line in logs, which in addition can be rotated.
> On 20 Mar 2023, at 15:27, Ilya Maximets <[email protected]> wrote: > > On 3/20/23 13:20, Vladislav Odintsov wrote: >> Hi Ilya, >> >> Ah, I didn’t see that its default was changed in newer versions... >> We run 2.17 where it’s off by default and I decided to submit a patch which >> is useful for that version. >> Anyway my opinion is if user has an ability to change the setting, it should >> be possible to get its actual value. At least in versions were it’s off by >> default. > > We also have this: > https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ > > This one we can actually treat as a bug fix and backport down to 2.17. > In case the logging is what is bothering you. I know that ovn-k8s, > for example, is calling this appctl frequently littering the log. > The change can fix at least that. > > Best regards, Ilya Maximets. > >> >>> On 20 Mar 2023, at 15:07, Ilya Maximets <[email protected]> wrote: >>> >>> On 3/20/23 10:24, Vladislav Odintsov wrote: >>>> In commit [1] there was added support to enable memory trimming on OVSDB >>>> tlog >>>> compation. However there was no option to get current setting value except >>>> log parsing. This patch adds new unixctl command >>>> 'ovsdb-server/show-memory-trim-on-compaction' to print current setting >>>> value. >>>> >>>> 1: >>>> https://github.com/openvswitch/ovs/commit/f38f98a2c0dd7fcaf20fbe11d1e67a9b2afc0b2a >>>> >>>> Signed-off-by: Vladislav Odintsov <[email protected]> >>>> --- >>>> NEWS | 4 ++++ >>>> ovsdb/ovsdb-server.c | 28 ++++++++++++++++++++++++++++ >>>> 2 files changed, 32 insertions(+) >>>> >>>> diff --git a/NEWS b/NEWS >>>> index 72b9024e6..8515f4aaa 100644 >>>> --- a/NEWS >>>> +++ b/NEWS >>>> @@ -17,6 +17,10 @@ Post-v3.1.0 >>>> in order to create OVSDB sockets with access mode of 0770. >>>> - QoS: >>>> * Added new configuration option 'jitter' for a linux-netem QoS type. >>>> + - OVSDB: >>>> + * New unixctl command 'ovsdb-server/show-memory-trim-on-compaction'. >>>> + This command shows current value for memory trimming setting for >>>> + OVSDB server. >>> >>> Hi, Vladislav. The memory trimming is enabled by default since 3.0. >>> And I'm not aware of any cases where it is beneficial to disable it. >>> The current appctl call was mostly kept for backward compatibility >>> and should be deprecated and removed in one of the future releases. >>> So, I'm not sure if we actually need to add a new knob for status >>> checking, unless you actually want to disable the trimming. >>> >>> What do you think? >>> >>> Best regards, Ilya Maximets. >> >> >> Regards, >> Vladislav Odintsov >> > Regards, Vladislav Odintsov _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
