On Fri, Mar 24, 2023 at 01:03:00PM +0100, Ilya Maximets wrote: > On 3/23/23 03:57, Nobuhiro MIKI wrote: > > On 2023/03/22 21:21, Simon Horman wrote: > >> On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote: > >>> Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. > >>> If it exists, the first address is retrieved. > >>> > >>> Signed-off-by: Nobuhiro MIKI <nm...@yahoo-corp.jp> > >> > >> Hi Miki-san, > >> > >> this also looks good to me. > >> I have made a few suggestions for improvements inline. > >> > > > > Hi Simon-san, > > > > Thanks for your review. > > > > Best Regards, > > Nobuhiro MIKI > > > >>> --- > >>> lib/conntrack.c | 4 +++- > >>> lib/flow.c | 26 ++++++++++++++++++++------ > >>> lib/flow.h | 3 ++- > >>> lib/ipf.c | 12 ++++++++---- > >>> lib/packets.h | 13 +++++++++++++ > >>> 5 files changed, 46 insertions(+), 12 deletions(-) > > <snip> > > >>> diff --git a/lib/packets.h b/lib/packets.h > >>> index 8626aac8d53f..abff24db016e 100644 > >>> --- a/lib/packets.h > >>> +++ b/lib/packets.h > >>> @@ -710,6 +710,10 @@ char *ip_parse_cidr_len(const char *s, int *n, > >>> ovs_be32 *ip, > >>> #define IPPROTO_UDPLITE 136 > >>> #endif > >>> > >>> +#ifndef IPPROTO_IPIP > >>> +#define IPPROTO_IPIP 4 > >>> +#endif > >>> + > >> > >> IPPROTO_IPIP has been around for a long time. > >> And I don't think other very old values, > >> like IPPROTO_UDP, are defined in this file > >> So, perhaps this isn't needed here? > >> > > > > Perhaps it is not necessary. > > I'll remove it for now. > > It seems still necessary to define it for sparse that doesn't use system in.h. > I.e. we need to define it in include/sparse/netinet/in.h, otherwise builds > with --enable-sparse are failing.
Ack, sorry for the noise. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
