Hi Han,

I had a look through the patches, and it all looks good to me. I really like the separation of switch and router datapaths and ports.

Acked-by: Mark Michelson <[email protected]>

On 3/21/23 02:02, Han Zhou wrote:
The refactor doesn't have any functional changes to the code, but to maintain
function dependencies more clearly at a finer grain level. As a byproduct it
also improves performance slightly.

The refactor touches a big part of northd code, so submit it before the real
incremental processing changes, to avoid the effort of continuously rebasing
a resolving conflicts.

Han Zhou (7):
   northd.c: Refactor to reduce indentation.
   northd.c: Simplify a code chunk by reusing existing ovn_port_get_peer.
   northd: Split switch ports and router ports.
   northd: Split switch and router datapaths.
   northd: Expose real inputs through function arguments.
   en-northd.c: Remove unused dependencies.
   northd: Move the datapaths arrays to ovn_datapaths struct.

  lib/lb.c                   |   15 +-
  lib/lb.h                   |    6 +-
  northd/en-lflow.c          |   15 +-
  northd/en-northd.c         |    8 +-
  northd/en-sync-sb.c        |   19 +-
  northd/inc-proc-northd.c   |   62 +-
  northd/mac-binding-aging.c |    2 +-
  northd/northd.c            | 5144 +++++++++++++++++++-----------------
  northd/northd.h            |   42 +-
  ovs                        |    2 +-
  10 files changed, 2803 insertions(+), 2512 deletions(-)


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to