On 3/30/23 04:17, Songtao Zhan wrote:
>
> To: [email protected],
> [email protected]
>
> The name of the current thread consists of a name with a maximum
> length of 16 bytes and a thread ID. The final name may be longer
> than 16 bytes. If the name is longer than 16 bytes, the thread
> name will fail to be set
>
> Signed-off-by: Songtao Zhan <[email protected]>
Looks reasonable to me, thanks! See some minor comments below.
Best regards, Ilya Maximets.
> ---
> lib/util.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/util.c b/lib/util.c
> index 96a71550d..023829694 100644
> --- a/lib/util.c
> +++ b/lib/util.c
> @@ -645,6 +645,10 @@ set_subprogram_name(const char *subprogram_name)
> free(subprogram_name_set(pname));
>
> #if HAVE_GLIBC_PTHREAD_SETNAME_NP
> + /* The maximum thead name including '\0' supported by the system is 16 */
I'd remove 'by the system' from the sentence above.
And the sentence should end with a period.
> + if (strlen(pname) > 15) {
> + pname[15] = '\0' ;
No need for the extra space before ';'.
> + }
> pthread_setname_np(pthread_self(), pname);
> #elif HAVE_NETBSD_PTHREAD_SETNAME_NP
> pthread_setname_np(pthread_self(), "%s", pname);
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
