On 3/30/23 10:10, Dumitru Ceara wrote: > On 3/29/23 22:26, [email protected] wrote: >> From: Daniel Alvarez Sanchez <[email protected]> >> >> The commit b8bf410a5 [0] broke the `ovs-vsctl add` command >> which now overwrites the value if it existed already. >> >> This patch reverts the code around the `cmd_add` function >> to restore the previous behavior. It also adds testing coverage >> for this functionality. >> >> [0] >> https://github.com/openvswitch/ovs/commit/b8bf410a5c94173da02279b369d75875c4035959 > > Hi Daniel, > > Thanks for the fix! Sorry for missing this at review last time. > >> >> Fixes: b8bf410a5 ("db-ctl-base: Use partial map/set updates for last add/set >> commands") > > The "Fixes" tag can be corrected by Ilya at apply time, I guess. > >> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2182767 >> Signed-off-by: Daniel Alvarez Sanchez <[email protected]> > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <[email protected]>
Thanks! I fixed the tag and applied the change. Also backported to 3.1. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
