Hi,
Thanks for your reply.
Our original idea is imitating OVS-TC, meter action and flow is
independence. First through
the proxy port create the meter, then flow use meter with meter id. So I only
add the proxy port,
doesn't revise the flow with proxy port. So you think this idea cant be
accepted?
As your said, when the flow first time use the meter/proxy port, we
offload the meter to the HW,
when the last flow with the meter/proxy port will be delete, we delete the
meter from the HW.
About your idea, I have some issue about modify the flow, because
the flow cant get the meter
status, so we can't through flow to modify the meter in the HW. We have two
way to solve it, one is modify
the meter, we delete all the flow with meter from the HW, the key is through
meter id lookup the all flow with
the meter id from the HW. Another is update the meter through the proxy port
in the HW. Do you think which
is better?
B.R.
Peng
> -----Original Message-----
> From: Eli Britstein <[email protected]>
> Sent: Thursday, March 30, 2023 8:34 PM
> To: Simon Horman <[email protected]>; [email protected]
> Cc: Ilya Maximets <[email protected]>; Chaoyong He
> <[email protected]>; Nole Zhang <[email protected]>;
> Kevin Liu <[email protected]>; oss-drivers <[email protected]>
> Subject: RE: [PATCH dpdk-latest v3 0/6] Add support for DPDK meter HW
> offload
>
> Hi
>
> The usage of the proxy port is wrong.
> All transfer offload should be migrated to use it. There was [1-4], but it was
> not completed.
>
> Meters should be created only on the proxy ports. As all offloads are moved
> to use proxy ports, this is how they are shared.
> Since we don't know the proxy port when meter is added, it can be lazy
> created upon the first flow that uses this meter/proxy-port (referenced
> counted), and destroy upon the last flow destroy using it.
> As there might be multiple "proxy" ports, there might be multiple HW meter
> objects associated with the same SW one. This should be managed.
>
> [1]
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=302525&state
> =*
> [2]
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=310413&state
> =*
> [3]
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=310415&state
> =*
> [4]
> http://patchwork.ozlabs.org/project/openvswitch/list/?series=342885&state
> =*
>
> Thanks,
> Eli
>
> >-----Original Message-----
> >From: Simon Horman <[email protected]>
> >Sent: Thursday, 30 March 2023 14:21
> >To: [email protected]
> >Cc: Ilya Maximets <[email protected]>; Eli Britstein
> ><[email protected]>; Chaoyong He <[email protected]>; Peng
> Zhang
> ><[email protected]>; Jin Liu <[email protected]>; oss-
> >[email protected]
> >Subject: [PATCH dpdk-latest v3 0/6] Add support for DPDK meter HW
> >offload
> >
> >External email: Use caution opening links or attachments
> >
> >
> >Hi,
> >
> >this series adds support for DPDK meter HW offload.
> >
> >Changes between v2 and v3.
> >* Use common API for DPDK and non-DPDK meter offloads
> >* Make use of netdev_ports_traverse to offload the meter
> >* Add dpdk-latest to subject prefix
> >
> >Changes between v1 and v2:
> >* Add the prox mechanism: add the meter by proxy id
> >* Change the offload interface from netdev-dpdk to the netdev-offload
> >* Changed base to dpdk-latest branch
> >
> >Peng Zhang (6):
> > netdev-offload-dpdk: use flow transfer proxy
> > netdev-offload: Let meter offload API can be used with DPDK
> > dpif-netdev: Offloading meter with DPDK
> > netdev-offload-dpdk: Implement meter offload API for DPDK
> > netdev-dpdk: add meter algorithms
> > netdev-dpdk-offload: Add support for meter action
> >
> > Documentation/howto/dpdk.rst | 5 +-
> > lib/dpif-netdev.c | 22 ++-
> > lib/netdev-dpdk.c | 306 +++++++++++++++++++++++++++++++++-
> > lib/netdev-dpdk.h | 43 +++++
> > lib/netdev-offload-dpdk.c | 97 +++++++++++
> > lib/netdev-offload-provider.h | 21 ++-
> > lib/netdev-offload-tc.c | 9 +-
> > lib/netdev-offload.c | 135 ++++++++++++++-
> > lib/netdev-offload.h | 9 +
> > 9 files changed, 633 insertions(+), 14 deletions(-)
> >
> >--
> >2.30.2
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
