On 3/31/23 13:52, Simon Horman wrote: > On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote: >> Prior to this commit, ACLs were evaluated and acted on in a single >> stage. With this commit, evaluation of ACLs and acting on an ACL's >> decision are separated into two stages. >> >> The acl_eval stage checks the ACL match and will set a bit to indicate >> the verdict of the ACL. The acl_action stage then checks the relevant >> bits to determine how to proceed. If no ACLs are matched, then the >> default ACL action is taken. >> >> A couple of notes about updated tests: >> - For test cases where I just had to increment a table number, I changed >> the check so the table numbers are masked. This should prevent similar >> changes from being needed later. >> - The port security test changes may seem odd. The issue here is that >> the ls_out_apply_port_sec table number changed from 9 to 10. This >> means that this table's flows now sort to a lower position than >> before. This is why the check had to change for this test. >> >> Signed-off-by: Mark Michelson <[email protected]> > > Hi Mark, > > this does not appear to apply on top of main any more.
Hi Simon, I didn't review this series yet but something that helps when dealing with patches that don't apply on top of main anymore is checking the branch 0-day bot created from the patchwork series: https://github.com/ovsrobot/ovn/tree/series_347327 It's: https://github.com/ovsrobot/ovn/tree/series_<series-id> Back to this specific series, that made me check the CI results and I see CI reports a memory leak: ================================================================= ==34989==ERROR: LeakSanitizer: detected memory leaks Direct leak of 3230 byte(s) in 102 object(s) allocated from: #0 0x499f1d in malloc (/home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/northd/ovn-northd+0x499f1d) #1 0x83fc64 in xmalloc__ /home/runner/work/ovn/ovn/ovs/lib/util.c:140:15 #2 0x83fd25 in xmalloc /home/runner/work/ovn/ovn/ovs/lib/util.c:175:12 #3 0x83fe9c in xvasprintf /home/runner/work/ovn/ovn/ovs/lib/util.c:230:9 #4 0x840081 in xasprintf /home/runner/work/ovn/ovn/ovs/lib/util.c:371:9 #5 0x4f777b in build_acl_action_lflows /home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/../../northd/northd.c:6695:13 #6 0x4f0719 in build_acls /home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/../../northd/northd.c:7091:5 #7 0x4e031f in build_lswitch_lflows_pre_acl_and_acl /home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/../../northd/northd.c:8491:9 #8 0x4db1f4 in build_lswitch_and_lrouter_iterate_by_od /home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/../../northd/northd.c:14655:5 #9 0x4ce847 in build_lflows_thread /home/runner/work/ovn/ovn/ovn-23.03.90/_build/sub/../../northd/northd.c:14772:21 #10 0x822363 in ovsthread_wrapper /home/runner/work/ovn/ovn/ovs/lib/ovs-thread.c:423:12 #11 0x7f042e8d6608 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x8608) SUMMARY: AddressSanitizer: 3230 byte(s) leaked in 102 allocation(s). Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
