On Fri, Mar 31, 2023 at 10:45 AM Eelco Chaudron <[email protected]> wrote: > > > > On 30 Mar 2023, at 17:57, Jon Kohler wrote: > > >> On Mar 28, 2023, at 1:32 PM, Mike Pattrick <[email protected]> wrote: > >> > >> On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron <[email protected]> wrote: > >>> > >>> Make the read of the current seq->value atomic, i.e., not needing to > >>> acquire the global mutex when reading it. On 64-bit systems, this > >>> incurs no overhead, and it will avoid the mutex and potentially > >>> a system call. > >>> > >>> For incrementing the value followed by waking up the threads, we are > >>> still taking the mutex, so the current behavior is not changing. The > >>> seq_read() behavior is already defined as, "Returns seq's current > >>> sequence number (which could change immediately)". So the change > >>> should not impact the current behavior. > >>> > >>> Signed-off-by: Eelco Chaudron <[email protected]>
I think after much discussion we've identified some additional areas that this work could be extended to, but there's nothing wrong with this patch as is. Acked-by: Mike Pattrick <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
