On 3/31/23 11:58, Ales Musil wrote: > On Mon, Mar 27, 2023 at 5:39 PM Dumitru Ceara <[email protected]> wrote: > >> Until now weekly OVN jobs would try to compile against OVS master >> branch. But that potentially contains changes that break API. For >> example a recent OVS commit [0] changed the signature of the >> daemonize_start() function. In order to avoid build failures due >> to such changes, adapt the weekly OVN CI job to compile against the most >> recent OVS stable branch commit. Most likely that won't contain changes >> that break APIs used by OVN. >> >> [0] >> https://github.com/openvswitch/ovs/commit/07cf5810de8da12c700324bc421bde92376abe06 >> >> Signed-off-by: Dumitru Ceara <[email protected]> >> > > Hi Dumitru, > this unfortunately breaks the container CI. As it is kinda unexpected to > do something with the git repos inside the build-x.sh. Would it be possible > to have it in the workflow instead?. That would also make it way more > obvious what > is the intention. >
Hi Ales, Thanks for your review! You're right it's more clear to just add the checkout to the workflow directly. I did that in v2: https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/ Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
