On 4/3/23 13:00, Simon Horman wrote:
> On Fri, Mar 31, 2023 at 03:22:44PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 30 Mar 2023, at 11:27, Faicker Mo wrote:
>>
>>> The device may be deleted and added with ifindex changed.
>>> The tc rules on the device will be deleted if the device is deleted.
>>> The func tc_del_filter will fail when flow del. The mapping of
>>> ufid to tc will not be deleted.
>>> The traffic will trigger the same flow(with same ufid) to put to tc
>>> on the new device. Duplicated ufid mapping will be added.
>>> If the hashmap is expanded, the old mapping entry will be the first entry,
>>> and now the dp flow can't be deleted.
>>>
>>> Signed-off-by: Faicker Mo <[email protected]>
>>
>> Changes look good to me, so if Simon’s tests pass over the weekend:
>>
>> Acked-by: Eelco Chaudron <[email protected]>
> 
> The weekend came and the weekend went.
> I checked just now and the loop has run the test 73014 times
> without recording any failures.
> 
> I think we are good here :)
> 
> Reviewed-by: Simon Horman <[email protected]>
> Tested-by: Simon Horman <[email protected]>

Thanks!  Applied.  Backported down to 2.17.

Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to