Hello: I've made a copy in my personal google account to be able to share the doc link to anyone: https://docs.google.com/document/d/1Q4IV4tTahPfAwEj5lenYzskpEk1Sp2zIYY1ZL_ws0DM/edit?usp=sharing. This link has commenter permissions.
Regards. On Tue, Apr 4, 2023 at 6:57 PM Ihar Hrachyshka <[email protected]> wrote: > Hi, > > thanks for v2. I will leave general comments to the series here, and I > will post some specific comments to corresponding patches where > appropriate. > > -- > > The series claims that VIF support for QoS was not present before. > ("add QoS support for logical switch port interfaces" etc.) This is > not correct. QoS min-rate filters are applied to LSP by Neutron. Then > - as intended - ovn-controller creates corresponding qdisc queues on > egress interfaces that control bandwidth via HTB. I confirm LSP > settings are working here: https://paste.centos.org/view/4eedac05 (you > can apply it to main; it passes). > > The series, for LSP ports, switches from setting queues on egress > interfaces to setting them on TAP interfaces. This is wrong. I think > Rodolfo has a more detailed explanation captured in document, (I hope > he can share it here shortly) but the gist is that physical interfaces > are hardware and provide the actual bandwidth, and that's where HTB > algo should run to shape traffic aggregated from all. > > On Fri, Mar 31, 2023 at 6:40 AM Lorenzo Bianconi > <[email protected]> wrote: > > > > Rework OVN QoS implementation in order to configure it through OVS QoS > > table instead of running tc command directly bypassing OVS. > > > > Changes since v1: > > - get rid of qos_ovs_port from logical_switch_port option column and let > ovn to > > compute it > > - add VIF QoS support > > - take into account qos_min_rate in port_has_qos_params > > > > Lorenzo Bianconi (4): > > controller: configure qos through ovs qos table and do not run tc > > directly > > controller: improve ovs port lookup by name and qos > > controller: add QoS support for logical switch port interfaces > > northd: take into account qos_min_rate in port_has_qos_params > > > > controller/binding.c | 429 +++++++++++++++++------------------- > > controller/binding.h | 5 +- > > controller/ovn-controller.c | 35 ++- > > controller/ovsport.c | 32 +++ > > controller/ovsport.h | 5 + > > northd/northd.c | 2 +- > > tests/system-ovn.at | 101 ++++++++- > > 7 files changed, 367 insertions(+), 242 deletions(-) > > > > -- > > 2.39.2 > > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
