On Thu, Jan 19, 2023 at 2:15 PM Ilya Maximets <[email protected]> wrote:
>
> Testing that RPMs can be built to catch possible spec file
> issues like missing dependencies.
>
> GitHub seems to have an agreement with Docker Hub about rate
> limiting of image downloads, so it should not affect us.
> We may switch to quay.io if that will ever become a problem
> in the future.
>
> Signed-off-by: Ilya Maximets <[email protected]>
It lgtm, just a few comments.
The deb jobs have a check on the generated python libraries.
Can't we have issues with rpms?
> ---
> .github/workflows/build-and-test.yml | 37 ++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index 82675b973..883d44b4e 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -242,3 +242,40 @@ jobs:
> with:
> name: deb-packages-${{ matrix.dpdk }}-dpdk
> path: '/home/runner/work/ovs/*.deb'
> +
> + build-rpm-fedora:
The existing job names are:
build-linux:
build-osx:
build-linux-deb:
So this new name does not seem to follow a convention (if there is one).
I would have expected "build-linux-rpm".
> + name: linux rpm fedora
> + runs-on: ubuntu-22.04
In this test, we don't care about a specific version of Ubuntu, all
that matters is to get a working container.
I would go with ubuntu-latest.
> + container: fedora:37
> + timeout-minutes: 30
> +
> + strategy:
> + fail-fast: false
--
David Marchand
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
