On 3/31/23 15:39, Dumitru Ceara wrote: > On 3/31/23 15:23, Dumitru Ceara wrote: >> On 3/31/23 14:53, Eelco Chaudron wrote: >>> >>> >>> On 31 Mar 2023, at 14:47, Dumitru Ceara wrote: >>> >>>> On 3/31/23 14:16, Eelco Chaudron wrote: >>>>> Add arping package so the "virtual port with floating IP -- ovn-northd" >>>>> tests are run. >>>>> >>>>> Signed-off-by: Eelco Chaudron <[email protected]> >>>>> --- >>>> >>>> Hi Eelco, >>>> >>>> Thanks for the patch, it's good to enable this test! >>>> >>>>> .github/workflows/test.yml | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml >>>>> index 90dc8a6f1..bf958db9b 100644 >>>>> --- a/.github/workflows/test.yml >>>>> +++ b/.github/workflows/test.yml >>>>> @@ -17,7 +17,8 @@ jobs: >>>>> dependencies: | >>>>> automake libtool gcc bc libjemalloc2 libjemalloc-dev \ >>>>> libssl-dev llvm-dev libelf-dev libnuma-dev libpcap-dev \ >>>>> - selinux-policy-dev ncat python3-scapy isc-dhcp-server >>>>> + selinux-policy-dev ncat python3-scapy isc-dhcp-server \ >>>>> + iputils-arping >>>> >>>> I see now the test running.. >>>> >>>> 277: virtual port with floating IP -- ovn-northd -- parallelization=yes >>>> -- ovn_monitor_all=yes FAILED (system-ovn.at:10191) >>>> >>>> .. and failing. >>>> >>>> Not your fault, of course, but I'd really prefer to fix the test (if >>>> it's a test issue) or OVN before enabling this in CI. Otherwise we'll >>>> have permanently "red" runs in CI which is also confusing. >>>> >>>> I'm not sure if you want and have time to look into this failure. If >>>> not, let me know, I can try to have a look next week. >>> >>> It ran fine when I tried this :( >>> https://github.com/chaudron/ovn/actions/runs/4574680800 >>> >> >> I see, thanks for sharing this! It seems this is a recent regression in >> OVN. I bisected it and it was introduced by e3bc68c3be69 ("northd: drop >> ct.inv packets in post snat and lb_aff_learn stages"). Lorenzo, Numan, >> do you have time to look into this please? >> > > +Lorenzo, Numan. > >> The offending patch has also been backported to branch-23.03 so we need >> a fix there too.
Thanks, Eelco! With the regression fixed on all stable branches I went ahead and applied your patch too. I also backported it to all branches down to 21.12. It shouldn't hurt to enable more tests everywhere. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
