On Thu, Apr 13, 2023 at 4:53 PM Dumitru Ceara <[email protected]> wrote:
> On 3/15/23 07:29, Ales Musil wrote: > > The containers will bring some benefits > > to the overall CI proccess: > > > > 1) Reproducibility, there is high chance > > that if the test is failing constantly on CI > > users can reproduce it by getting the same image > > and running the affect test. > > > > 2) Ease of use, for any new contributor it should > > be easier to have working test environment by just > > mimicking the steps in test.yml. > > > > 3) We can avoid installation of packages during every > > test run. The overhead is not that big ~2 min, but > > it still can be considered as plus. > > > > In order to do that there are few steps required. > > This series add some missing pieces to the ci.sh > > script that was introduced earlier. > > > > There is a new Dockerfile for Ubuntu based images > > as well as addition of some missing packages to the > > existing Fedora one. > > > > To keep the images up to date the process is > > automated by running the image build job every week. > > The job will produce both Fedora and Ubuntu images > > for x86_64 and arm64. The list of architectures > > and distros can be extended anytime. > > > > The last two patches that actually do the transition > > itself are marked as RFC for now because they need the > > images to be published first. They are kept in the series > > to show what is the direction of this series. > > > > All steps have been tested on my fork. > > > > The automatic build: > https://github.com/almusil/ovn/actions/runs/4415557943 > > The GH test run: https://github.com/almusil/ovn/actions/runs/4419187229 > > The Cirrus CI run: https://cirrus-ci.com/build/4586570494246912 > > > > Ales Musil (9): > > ci: Add missing packages to the container > > ci: Use the latest Fedora as base image > > ci: Add argument for the py-requirements path > > ci: Add Ubuntu based Dockerfile > > ci: Add argument to archive logs on failure > > ci: Mark the ovn workdir as git safe within container > > ci: Add automation for building the containers > > Thanks, Ales for the series and Ilya and Frode for reviews! > > I went ahead and applied the first 7 patches (the non-RFC ones) and also > triggered the "Containers" workflow [0] on GitHub to ensure we get a > first container image. > > I had to make a minor change to patch 4/9 to also install > iputils-arping, gcc-multilib, libunbound-dev and libunwind-dev. This is > to match what we currently install in CI. > > > ci: Use container to run the tests > > ci: Switch Cirrus CI to use the new image > > > > Ales, once the "Containers" workflow [0] finishes, can you please post a > new series to include these last two patches? > Yes, thank you! > > Thanks again! > > Regards, > Dumitru > > [0] https://github.com/ovn-org/ovn/actions/runs/4690640224 > > Regards, Ales -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> [email protected] IM: amusil <https://red.ht/sig> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
