On Mon, 2023-04-24 at 16:42 -0500, Terry Wilson wrote: > > On Fri, Apr 21, 2023 at 3:29 AM Stefan Hoffmann > <[email protected]> wrote: > > In some cases ovsdb server or relay gets restarted, ovsdb python > > clients > > may keep the local socket open. Instead of reconnecting a lot of > > failures > > will be logged. > > This can be reproduced with ssl connections to the server/relay and > > restarting it, so it has the same IP after restart. > > > > This patch catches the Exceptions at do_handshake to recreate the > > connection on the client side. > > > > > Is this something we can add some tests for? I know we have some > other tests that involve restarts, but I don't think they involve > python clients or SSL.
I can try to find a proper place to add such an test. Can you point me to the correct place to add python clients to that test? But I'm not sure, if we run always into that issue at a restart. > > > Reviewed-by: Simon Horman <[email protected]> > > Signed-off-by: Stefan Hoffmann <[email protected]> > > Signed-off-by: Luca Czesla <[email protected]> > > Signed-off-by: Max Lamprecht <[email protected]> > > Co-authored-by: Luca Czesla <[email protected]> > > Co-authored-by: Max Lamprecht <[email protected]> > > --- > > python/ovs/stream.py | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/python/ovs/stream.py b/python/ovs/stream.py > > index ac5b0fd0c..b32341076 100644 > > --- a/python/ovs/stream.py > > +++ b/python/ovs/stream.py > > @@ -824,7 +824,8 @@ class SSLStream(Stream): > > self.socket.do_handshake() > > except ssl.SSLWantReadError: > > return errno.EAGAIN > > - except ssl.SSLSyscallError as e: > > + except (ssl.SSLSyscallError, ssl.SSLZeroReturnError, > > + ssl.SSLEOFError, OSError) as e: > > return ovs.socket_util.get_exception_errno(e) > > > > return 0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
