On Fri, Apr 21, 2023 at 05:16:47PM +0200, Adrian Moreno wrote:
> tc uses these "rtab" tables to estimate the time (ticks) that it takes
> to send a packet of different sizes. In preparation for the introduction
> of 64-bit rates, add an argument to tc_put_rtab() to allow an external
> 64-bit rate.
> 
> Signed-off-by: Adrian Moreno <[email protected]>
> ---
>  lib/netdev-linux.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 6d5cf8114..60a0a8b2a 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -512,7 +512,8 @@ static int tc_del_qdisc(struct netdev *netdev);
>  static int tc_query_qdisc(const struct netdev *netdev);
>  
>  void
> -tc_put_rtab(struct ofpbuf *msg, uint16_t type, const struct tc_ratespec 
> *rate);
> +tc_put_rtab(struct ofpbuf *msg, uint16_t type, const struct tc_ratespec 
> *rate,
> +            uint64_t bps);

Its unfortunate that there are now two parameters relating to the rate.
But I think this is a case of playing the hand we've been dealt.
And as I have no better idea I'm ok with this.

Reviewed-by: Simon Horman <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to