On 5/3/23 17:17, Numan Siddique wrote: > On Thu, Mar 30, 2023 at 8:54 AM Dumitru Ceara <[email protected]> wrote: >> >> On 3/29/23 16:01, [email protected] wrote: >>> From: Numan Siddique <[email protected]> >>> >>> This patch adds a couple of jobs using ovn-fake-multinode. >>> It first builds 2 ovn-fake-multinode container images >>> - one with OVN 22.03 >>> - one with present main. >>> >>> The first job deploys ovn-fake-multinode with the main >>> OVN and runs simple tests provided by ovn-fake-multinode [1]. >>> >>> The second job deploys ovn-fake-multinode setup with the >>> central image using OVN 22.03 and chassis image using main OVN. >>> This job tests the scenario >>> - ovn-northd and OVN dbs are running the most recent LTS. >>> - ovn-controller is running the latest commit from the branch. >>> >>> The workflow is right now scheduled to trigger on midnight everyday. >>> Once we cache the built image or reduce the overall run time of >>> this workflow we can enable for every push. >>> >>> [1] - >>> https://github.com/ovn-org/ovn-fake-multinode/blob/main/.ci/test_basic.sh >>> >>> Signed-off-by: Numan Siddique <[email protected]> >>> --- >> >> I have a few minor comments, feel free to add my ack when you apply the >> patch if you address them: >> >> Acked-by: Dumitru Ceara <[email protected]> > > Thanks Dumitru and Simon for the reviews. > > It took a while for me to address the comments and apply. > > I applied both the patches to the main branch with the below changes.
Hi Numan, Thanks for applying the patch but I have a comment regarding re-adding .ci/linux-prepare.sh. > > Also I had to add back the file .ci/linux-prepare.sh as the fake multi > node system tests would need to compile ovn. > > I could have avoided that and instead installed the > 'linux-prepare.sh' stuff in the workflow yaml file itself. > But I felt it easier to just add back the file. > I don't really think we need this. The "proper" way IMO is to run this from a container that uses the pre-built ghcr.io/ovn-org/ovn-tests:ubuntu image. We build this one weekly and it should have all required dependencies. But I failed while trying to do that so instead I went for skipping sparse for the build that's used for running the tests. We don't care about sparse in that case anyway. In the process, I also spotted a few bugs and some improvement opportunities. I posted a patch series here: https://patchwork.ozlabs.org/project/ovn/list/?series=353636&state=* Please let me know what you think! Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
