On 5/10/23 13:48, Stefan Hoffmann wrote: > On Wed, 2023-05-10 at 13:15 +0200, Ilya Maximets wrote: >> On 5/10/23 11:43, Stefan Hoffmann wrote: >>> Define bash function as macro now. Later we can extend this macro for other >>> usecases. >>> >>> Signed-off-by: Stefan Hoffmann <[email protected]> >> >> Hi, Stefan. Is there any difference between this patch and the >> previous (also v2): >> >> https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ >> ? >> >> I'm a bit confused on why it was sent a second time. >> >> Best regards, Ilya Maximets. > > Hi, > > sorry for the confusion. It's the exact same change. I tried to get a > green Pipeline. I guess, there is a better way to do so. Sorry for the > mess. >
The main problem is that incomplete sets are not getting tested at all. So, you need to send both patches as a set. Also, you need to increase version number regardless. Just put the version history under the '---' in the commit message describing what changed or why the new version was sent. With the patch set being incomplete and with the version numbers unchanged, the automation is confused. You only had one test #27 failed and it's a known flaky test, so there was no real need to re-port. You'll need to re-post the set as v3 to un-confuse the automation. I'll have a quick look over the patch set today, so maybe you'll have something to fix along the way and not just re-post. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
