On 5/11/23 15:38, Stefan Hoffmann wrote: > This tests stream.c and stream.py with ssl connection at > CHECK_STREAM_OPEN_BLOCK. > For the tests, ovsdb needs to be build with libssl. > > Signed-off-by: Stefan Hoffmann <[email protected]> > --- > > Changes based on comments from Ilya Maximets: > use m4_join; use m4_substr directly at call, without using variable in > between > > Hint: at some places we can't use brackets, as m4 seems to not resolve the > variables otherwise. Mail with comments at this places will follow. > > tests/ovsdb-idl.at | 31 +++++++++++++++++++++++++++---- > tests/test-stream.c | 12 +++++++++++- > tests/test-stream.py | 18 ++++++++++++++++++ > 3 files changed, 56 insertions(+), 5 deletions(-)
Applied. Thanks! It's always nice to have improved test coverage. For the future - If you have a patch set (more than 1 patch), it's better to have a cover letter and patches sent in reply to this cover letter. This way they are easier to manage in the inbox. You may use '--cover-letter' option of 'git format-patch' for that. And if you're using 'git send-email cover patch1 patch2 ...', it will by default provide the described behavior (patches in reply to cover letter). Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
