On Mon, May 15, 2023 at 12:33 PM Ilya Maximets <[email protected]> wrote: > > On 5/15/23 18:05, [email protected] wrote: > > From: Numan Siddique <[email protected]> > > > > Update the apt cache before installing dependencies in > > the multinode test jobs, otherwise installing depencies > > may fail if the cache is out dated. > > > > Suggested-by: Ilya Maximetes <[email protected]> > > Signed-off-by: Numan Siddique <[email protected]> > > --- > > .github/workflows/ovn-fake-multinode-tests.yml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/.github/workflows/ovn-fake-multinode-tests.yml > > b/.github/workflows/ovn-fake-multinode-tests.yml > > index e24d8ce873..9c10a8fc01 100644 > > --- a/.github/workflows/ovn-fake-multinode-tests.yml > > +++ b/.github/workflows/ovn-fake-multinode-tests.yml > > @@ -100,7 +100,9 @@ jobs: > > > > steps: > > - name: install required dependencies > > - run: sudo apt install -y ${{ env.dependencies }} > > + run: | > > + sudo apt update > > + sudo apt install -y ${{ env.dependencies }} > > Will the step fail if update fails? I don't remember how that works. > In case it does, it may be better to || true it. See: > > https://github.com/openvswitch/ovs/commit/d5c429a303341c2bf07090193e640434b3c51080
Sure. Sounds good to me. I'll wait for other comments. I guess I can modify this before applying the patch if I get ack from you or others (if no other comments) Thanks Numan > > Best regards, Ilya Maximets. > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
