On 26 May 2023, at 13:05, Simon Horman wrote:
> On Fri, May 26, 2023 at 12:43:52PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 15 May 2023, at 10:23, Roi Dayan wrote:
>>
>>> From: Gavin Li <[email protected]>
>>>
>>> Add TC offload support for filtering vxlan tunnels with gbp option
>>>
>>> Signed-off-by: Gavin Li <[email protected]>
>>> Reviewed-by: Gavi Teitz <[email protected]>
>>> Reviewed-by: Roi Dayan <[email protected]>
>>
>> One comment below, the rest looks good to me.
>>
>> //Eelco
>
> Thanks Eelco.
Just to clarify, this is for patch 5 only. Have some more comments on 6 and 7.
> ...
>
>>> @@ -696,6 +697,38 @@ nl_parse_geneve_key(const struct nlattr *in_nlattr,
>>> return 0;
>>> }
>>>
>>> +static int
>>> +nl_parse_vxlan_key(const struct nlattr *in_nlattr,
>>> + struct tc_flower_tunnel *tunnel)
>>> +{
>>> + const struct ofpbuf *msg;
>>> + struct nlattr *nla;
>>> + struct ofpbuf buf;
>>> + uint32_t gbp_raw;
>>> + size_t left;
>>> +
>>> + nl_attr_get_nested(in_nlattr, &buf);
>>> + msg = &buf;
>>> +
>>> + NL_ATTR_FOR_EACH (nla, left, ofpbuf_at(msg, 0, 0), msg->size) {
>>> + uint16_t type = nl_attr_type(nla);
>>> +
>>> + switch (type) {
>>> + case TCA_FLOWER_KEY_ENC_OPT_VXLAN_GBP:
>>> + gbp_raw = nl_attr_get_u32(nla);
>>> + odp_decode_gbp_raw(gbp_raw, &tunnel->gbp.id,
>>> + &tunnel->gbp.flags);
>>> + tunnel->gbp.id_present = true;
>>> + break;
>>> + default:
>>> + VLOG_ERR_RL(&error_rl, "failed to parse vxlan tun options");
>>> + return EINVAL;
>>
>> Should this not be a warning, and silently ignore it? What if a newer kernel
>> reports an additional value, we do not need, it will break existing
>> implementations.
>
> Roi,
>
> could you address this and post v4?
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
