On 31 May 2023, at 15:22, David Marchand wrote:

> Caught while reviewing code.
>
> Fixes: aca2f8a8a6b6 ("netdev-offload-dpdk: Implement HW miss packet recover 
> for vport.")
> Fixes: b6cabb8f8f80 ("netdev: Split up netdev offloading to separate module.")
> Signed-off-by: David Marchand <[email protected]>

Changes look god to me (visual inspection only).

Acked-by: Eelco Chaudron <[email protected]>

> ---
>  lib/netdev-offload-dpdk.c | 2 +-
>  lib/netdev-offload.h      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index 2d7858f51c..14bc877719 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netdev-offload-dpdk.c
> @@ -2672,7 +2672,7 @@ netdev_offload_dpdk_hw_miss_packet_recover(struct 
> netdev *netdev,
>      if (rte_restore_info.flags & RTE_FLOW_RESTORE_INFO_ENCAPSULATED) {
>          if (!vport_netdev->netdev_class ||
>              !vport_netdev->netdev_class->pop_header) {
> -            VLOG_ERR_RL(&rl, "vport nedtdev=%s with no pop_header method",
> +            VLOG_ERR_RL(&rl, "vport netdev=%s with no pop_header method",
>                          netdev_get_name(vport_netdev));
>              ret = EOPNOTSUPP;
>              goto close_vport_netdev;
> diff --git a/lib/netdev-offload.h b/lib/netdev-offload.h
> index edc843cd99..47f8e6f48b 100644
> --- a/lib/netdev-offload.h
> +++ b/lib/netdev-offload.h
> @@ -72,7 +72,7 @@ struct offload_info {
>                                       * sync with datapath recirc ids. */
>
>      /*
> -     * The flow mark id assigened to the flow. If any pkts hit the flow,
> +     * The flow mark id assigned to the flow. If any pkts hit the flow,
>       * it will be in the pkt meta data.
>       */
>      uint32_t flow_mark;
> -- 
> 2.40.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to