On 6/8/23 09:07, Ales Musil wrote:
> Skip GARP packet with link-local (ip6.dst == ff00::/8)
> address being advertised when "always_learn_from_arp_request=false",
> this should prevent huge grow of MAC Binding table. To keep the option
> consistent overwrite the previous MAC with LLA if it was
> already stored in DB.
>
> Reported-at: https://bugzilla.redhat.com/2211240
> Signed-off-by: Ales Musil <[email protected]>
> ---
> v2: Remove leftover from previous tests.
> v3: Address comments from Ihar:
> - Move the condition next to the other "nd_na" flow.
> - Update the comment for the flow.
> v4: Address comments from Dumitru:
> - Make sure we skip only unsolicited NAs.
> - Add relevant system test.
> ---
Thanks, Ales and Ihar!
I folded in a minor change:
diff --git a/northd/northd.c b/northd/northd.c
index c30b5b446c..c5df88963d 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -12449,7 +12449,13 @@ build_neigh_learning_flows_for_lrouter(
ds_cstr(actions));
if (!learn_from_arp_request) {
- /* Add flow to skip GARP LLA if we don't know it already. */
+ /* Add flow to skip GARP LLA if we don't know it already.
+ * From RFC 2461, section 4.4, Neighbor Advertisement Message
+ * Format, the Destination Address should be:
+ * For solicited advertisements, the Source Address of
+ * an invoking Neighbor Solicitation or, if the
+ * solicitation's Source Address is the unspecified
+ * address, the all-nodes multicast address. */
ds_clear(actions);
ds_put_format(actions, REGBIT_LOOKUP_NEIGHBOR_RESULT
" = lookup_nd(inport, ip6.src, nd.tll); "
Then I applied to main and backported down to 21.12. In order for the
test to work I also backported the commit that adds fmt_pkt() to 21.12.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
